Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid throwing on ResourceSubject dispose if source sequence terminated exceptionally #1293

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Avoid throwing on ResourceSubject dispose if source sequence terminated exceptionally #1293

merged 2 commits into from
Mar 18, 2023

Conversation

glopesdev
Copy link
Member

This PR adds a guard on ResourceSubject dispose to avoid throwing if the source sequence terminated exceptionally. In this situation, the exception will be propagated to the downstream observer regardless, and calling Dispose is simply a cleanup side-effect.

Fixes #1256

@glopesdev glopesdev added the fix Pull request that fixes an issue label Mar 18, 2023
@glopesdev glopesdev added this to the 2.8 milestone Mar 18, 2023
@glopesdev glopesdev merged commit f387940 into bonsai-rx:main Mar 18, 2023
@glopesdev glopesdev deleted the issue-1256 branch March 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Pull request that fixes an issue
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

ResourceSubject throws on dispose if source sequence terminates exceptionally
1 participant
@glopesdev